DM-46287: Make image binning a subtask for IsrTask #349
Conversation
| storageClass=self.binnedExposure.storageClass, | ||
| dimensions=frozenset(config.exposureDimensions), | ||
| ) | ||
| if config and config.exposureStorageClass != self.inputExposure.storageClass: |
There was a problem hiding this comment.
Do you have any expected cases where the storageClass would need to change?
There was a problem hiding this comment.
I think this also would cause problems with the check on L193, as that will raise if the storageClass isn't an Exposure. This does allow ExposureD, so maybe a comment here mentioning that although the storageClass can be changed, if it isn't some kind of Exposure, it's going to cause problems.
There was a problem hiding this comment.
I added this to ensure that the output storage class would always match the input storage class. While I could have the input and output storage classes as the generic Exposure, and it would be happy with any of the sub-types as input, any subtype information (I,F,D etc) would be lost on the output (at least that's my understanding).
I can certainly add the comment. [Late edit: Rather than add a comment, I've added an extra line to the config doc to state that it must be of type Exposure or one of its sub-types.]
jrmullaney
force-pushed
the
tickets/DM-46287
branch
2 times, most recently
from
5851362
to
6c17775
Compare
IsrTask subtasks BinExposureTask to perform exposure binning.
IsrTaskLSST subtasks BinExposureTask to perform exposure binning.
jrmullaney
force-pushed
the
tickets/DM-46287
branch
from
6c17775
to
1c10223
Compare
No description provided.